Add class name to the run/debug all tests #2416
Conversation
akshita31
requested review from
DustinCampbell and
rchande
and removed request for
DustinCampbell
|
What did the output look like before? |
|
@TheRealPiotrP Just added the thing highlighted in yellow. Small change |
src/features/codeLensProvider.ts
Outdated
| @@ -53,23 +54,25 @@ class RunTestsCodeLens extends TestCodeLens { | |||
| constructor( | |||
| range: protocol.V2.Range, | |||
| fileName: string, | |||
| name: string, | |||
There was a problem hiding this comment.
all the other names here are qualified, fileName, testMethodNames, etc.
what does name mean??
There was a problem hiding this comment.
It is the name of that particular entity, when it is a method it will be the method name, when it is the class, it will be the class name. Any suggestions ? Does DisplayName sound better ?
There was a problem hiding this comment.
@rchande Got any suggestions for the name here?
Codecov Report
@@ Coverage Diff @@
## master #2416 +/- ##
==========================================
+ Coverage 63.05% 63.28% +0.22%
==========================================
Files 88 88
Lines 3987 3998 +11
Branches 564 564
==========================================
+ Hits 2514 2530 +16
+ Misses 1311 1306 -5
Partials 162 162
Continue to review full report at Codecov.
|
| @@ -188,8 +191,8 @@ function createCodeLensesForElement(element: Structure.CodeElement, fileName: st | |||
| let range = element.Ranges[SymbolRangeNames.Name]; | |||
|
|
|||
| if (range && testFramework && testMethodName) { | |||
| results.push(new RunTestsCodeLens(range, fileName, /*isTestContainer*/ false, testFramework, [testMethodName])); | |||
| results.push(new DebugTestsCodeLens(range, fileName, /*isTestContainer*/ false, testFramework, [testMethodName])); | |||
| results.push(new RunTestsCodeLens(range, fileName, element.DisplayName,/*isTestContainer*/ false, testFramework, [testMethodName])); | |||
There was a problem hiding this comment.
Does TS have the equivalent of C# named arguments? It would be neat to use those instead of the comment...
There was a problem hiding this comment.
There is object destructuring , but should we do that here microsoft/TypeScript#467 (comment)
src/features/codeLensProvider.ts
Outdated
| @@ -53,23 +54,25 @@ class RunTestsCodeLens extends TestCodeLens { | |||
| constructor( | |||
| range: protocol.V2.Range, | |||
| fileName: string, | |||
| name: string, | |||
| @@ -188,8 +191,8 @@ function createCodeLensesForElement(element: Structure.CodeElement, fileName: st | |||
| let range = element.Ranges[SymbolRangeNames.Name]; | |||
|
|
|||
| if (range && testFramework && testMethodName) { | |||
| results.push(new RunTestsCodeLens(range, fileName, /*isTestContainer*/ false, testFramework, [testMethodName])); | |||
| results.push(new DebugTestsCodeLens(range, fileName, /*isTestContainer*/ false, testFramework, [testMethodName])); | |||
| results.push(new RunTestsCodeLens(range, fileName, element.DisplayName,/*isTestContainer*/ false, testFramework, [testMethodName])); | |||
The output will now look like this