-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple stages for Azure Pipeline #524
Conversation
Can we not rebuild in the subsequent stages? We should just build once in the first stage and reuse the binaries in the testing stages. |
Is this ready for review? |
Yea, this is ready for review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have few minor comments but the general approach looks good to me. @Niharikadutta also verified the generated artifacts from the internal build pipeline.
forwardCompatibleRelease: '0.9.0' | ||
backwardCompatibleRelease: '0.9.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason the order got flipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just thought the order of E2E FC Tests
, E2E BC Tests
more readable. So flip the order here to be consistent. But I can convert it back. Please let me know what is preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, not sure why it's more readable, but it's fine.
Btw, the azure-pipeline.xml is getting too long to maintain. Can you update this with templates, https://docs.microsoft.com/en-us/azure/devops/pipelines/process/templates?view=azure-devops? E2E tests are good candidates. You can do this as a follow-up PR. |
Sounds good, E2E tests could be templates. Will do as a follow-up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @elvaliuliuliu!
This PR adds multiple stages for Azure Pipeline which will fix #509 , the Azure Pipeline will have the following stages:
(Once the build is finished successfully, the following three testing stages will start)