Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple stages for Azure Pipeline #524

Merged
merged 42 commits into from
Jun 13, 2020

Conversation

elvaliuliuliu
Copy link
Contributor

@elvaliuliuliu elvaliuliuliu commented May 18, 2020

This PR adds multiple stages for Azure Pipeline which will fix #509 , the Azure Pipeline will have the following stages:

  • Build Sources: Build current sources
    (Once the build is finished successfully, the following three testing stages will start)
  • E2E Tests: Run current E2E tests
  • E2E Forward Compatibility Tests: Run E2E tests in the lastest compatible release with current worker
  • E2E Backward Compatibility Tests: Run current E2E tests with the lastest compatible worker

@elvaliuliuliu elvaliuliuliu changed the title [WIP] Multiple stages for the Azure Pipeline Add multiple stages for Azure Pipeline May 19, 2020
@imback82
Copy link
Contributor

Can we not rebuild in the subsequent stages? We should just build once in the first stage and reuse the binaries in the testing stages.

@elvaliuliuliu elvaliuliuliu changed the title Add multiple stages for Azure Pipeline [WIP] Add multiple stages for Azure Pipeline May 22, 2020
@elvaliuliuliu elvaliuliuliu changed the title [WIP] Add multiple stages for Azure Pipeline Add multiple stages for Azure Pipeline Jun 2, 2020
@imback82 imback82 added the enhancement New feature or request label Jun 4, 2020
@imback82
Copy link
Contributor

imback82 commented Jun 4, 2020

Is this ready for review?

@elvaliuliuliu
Copy link
Contributor Author

Is this ready for review?

Yea, this is ready for review. Thanks!

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few minor comments but the general approach looks good to me. @Niharikadutta also verified the generated artifacts from the internal build pipeline.

forwardCompatibleRelease: '0.9.0'
backwardCompatibleRelease: '0.9.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason the order got flipped?

Copy link
Contributor Author

@elvaliuliuliu elvaliuliuliu Jun 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thought the order of E2E FC Tests, E2E BC Tests more readable. So flip the order here to be consistent. But I can convert it back. Please let me know what is preferred.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, not sure why it's more readable, but it's fine.

azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
@imback82
Copy link
Contributor

Btw, the azure-pipeline.xml is getting too long to maintain. Can you update this with templates, https://docs.microsoft.com/en-us/azure/devops/pipelines/process/templates?view=azure-devops? E2E tests are good candidates. You can do this as a follow-up PR.

@elvaliuliuliu
Copy link
Contributor Author

elvaliuliuliu commented Jun 13, 2020

Btw, the azure-pipeline.xml is getting too long to maintain. Can you update this with templates, https://docs.microsoft.com/en-us/azure/devops/pipelines/process/templates?view=azure-devops? E2E tests are good candidates. You can do this as a follow-up PR.

Sounds good, E2E tests could be templates. Will do as a follow-up PR.

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @elvaliuliuliu!

@imback82 imback82 merged commit e43a0a4 into dotnet:master Jun 13, 2020
@elvaliuliuliu elvaliuliuliu deleted the elva/multi_stages branch June 13, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Multiple stages for the Azure Pipeline
2 participants