Follow-up on updating maintenance-packages dependencies conditioned to only DotNetBuildSourceOnly != true #45155
Assignees
Labels
Comments
carlossanlop
added a commit
to carlossanlop/runtime
that referenced
this issue
Nov 26, 2024
latest when not in source-build. Tracking issue: dotnet/sdk#45155
carlossanlop
added a commit
to carlossanlop/roslyn
that referenced
this issue
Nov 27, 2024
… source build is true. Tracking issue: dotnet/sdk#45155
ViktorHofer
pushed a commit
to dotnet/roslyn
that referenced
this issue
Nov 27, 2024
… source build is true. Tracking issue: dotnet/sdk#45155 (#76076)
carlossanlop
added a commit
to carlossanlop/msbuild
that referenced
this issue
Dec 3, 2024
…n source build is true. Tracking issue: dotnet/sdk#45155
carlossanlop
added a commit
that referenced
this issue
Dec 4, 2024
…ages when source build is true. Tracking issue: #45155
rainersigwald
pushed a commit
to dotnet/msbuild
that referenced
this issue
Dec 5, 2024
… source build only (#11077) * Only update msbuild dependencies coming from maintenance-packages when source build is true. Tracking issue: dotnet/sdk#45155 * Revert Microsoft.IO.Redist line, SB does not use it.
carlossanlop
added a commit
to carlossanlop/razor
that referenced
this issue
Dec 9, 2024
maintenance-packages when source build is true. Tracking issue: dotnet/sdk#45155
carlossanlop
added a commit
that referenced
this issue
Dec 9, 2024
maintenance-packages when source build is true. Tracking issue: #45155
davidwengier
added a commit
to dotnet/razor
that referenced
this issue
Dec 10, 2024
…source build is true (#11285) Tracking issue: dotnet/sdk#45155 Unblocks: dotnet/sdk#45042 @ViktorHofer @ericstj @MichaelSimons @akoeplinger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This sdk deps flow PR from runtime failed because we shipped new package versions from dotnet/maintenance-packages for System.Buffers, System.Memory, System.Runtime.CompilerServices.Unsafe, System.Numerics.Vectors and System.Threading.Tasks.Extensions.
System.Memory in particular is failing in dotnet/roslyn due to not being able to find System.ReadOnlySpan, which is provided by the package. The underlying root cause is that msbuild is forcing the package version to downgrade. Until we get msbuild to update the package versions, roslyn cannot have those package versions updated.
The sdk deps flow PR is getting at least 2 patches to condition those deps new versions to only happen when not in source build. We will need to take those conditions eventually when the timing is right (maily after msbuild update flows to roslyn).
cc @ViktorHofer @ericstj
The text was updated successfully, but these errors were encountered: