-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] [iOS][non-icu] HybridGlobalization Get available locales #93751
Conversation
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsBackport of #93594 to release/8.0 /cc @steveisok @mkhamoyan Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos Issue DetailsBackport of #93594 to release/8.0 /cc @steveisok @mkhamoyan Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
When ready, please send an email to Tactics requesting approval. Friendly reminder that we need this merged before 4pm tomorrow Friday 20th to ensure it goes into GA. |
Approved over email by tactics. |
That ios leg is taking forever to finish... and I'm waiting for it since it looks relevant to this change. |
It timed out. That tells me the helix queue is really backed up. The tvOS leg passed, so that is a good enough validation for me. |
|
Backport of #93594 to release/8.0
/cc @steveisok @mkhamoyan
Customer Impact
A customer reported #93514 where CultureInfo.GetCultures always returned an empty array when hybrid globalization was enabled. Hybrid globalization is a new opt-in feature where we rely on some native iOS API’s in order to reduce our dependence on ICU. In this case, it appears that when we changed our ICU filter to reduce the data we carry, we missed needing to make this native API call.
The fix was to call into the proper iOS API to get all the available locales on the device.
Testing
We added two new automated tests to validate the calls to GetCultures returns more than 0 elements.
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.