[release/6.0-staging] Fix JsonDocument thread safety. #92832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsBackport of #76716 to release/6.0-staging /cc @eiriktsarpalis Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
eiriktsarpalis
force-pushed
the
jsondocument-thread-safety-6.0
branch
from
dadadd6 to
fadec73
Compare
eiriktsarpalis
added
the
Servicing-consider
eiriktsarpalis
requested review from
carlossanlop and
ericstj
and removed request for
steveharter
ericstj
added
Servicing-approved
ericstj
approved these changes
Sep 30, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76716 to release/6.0-staging
/cc @eiriktsarpalis
Customer Impact
Even though the
JsonDocument/JsonElementtypes are documented as immutable/thread safe values, the current implementation suffers from a concurrency bug that can result in incorrect strings being returned when multiple threads attempt to call theGetString()method on the same document. This can result in nondeterministic bugs including potential privacy or security problems.Testing
Added an OuterLoop test validating the absence of the problem.
Risk
Low. This PR removes the cache that was causing the issue. We have concluded that the removal of the cache should not contribute to any perf regressions in real-life scenaria.