Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0][wasm] Fix Wasm.Build.Tests failing due to an old skiasharp reference #92747

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[release/8.0][wasm] Fix Wasm.Build.Tests failing due to an old skiasharp reference #92747

merged 1 commit into from
Sep 28, 2023

Conversation

radical
Copy link
Member

@radical radical commented Sep 28, 2023

WBT: Update skiasharp reference

Failed with:
blz_deploy_on_build_Debug_True_npl3f0nk_qee.csproj : error NU1903: Package 'SkiaSharp' 2.88.4-preview.76 has a known high severity vulnerability

@radical
[wasm] WBT: Update skiasharp reference
eb54674 
`blz_deploy_on_build_Debug_True_npl3f0nk_qee.csproj : error NU1903: Package 'SkiaSharp' 2.88.4-preview.76 has a known high severity vulnerability`
@radical radical added the arch-wasm WebAssembly architecture label Sep 28, 2023
@ghost
Copy link

ghost commented Sep 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

WBT: Update skiasharp reference

Failed with:
blz_deploy_on_build_Debug_True_npl3f0nk_qee.csproj : error NU1903: Package 'SkiaSharp' 2.88.4-preview.76 has a known high severity vulnerability

Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@ghost ghost assigned radical Sep 28, 2023
@radical radical added Servicing-consider Issue for next servicing release review and removed area-Build-mono labels Sep 28, 2023
@radical
Copy link
Member Author

radical commented Sep 28, 2023

Test only change to fix failing test on release/8.0 branch.

@radical radical mentioned this pull request Sep 28, 2023
Closed
carlossanlop
carlossanlop approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell mode: Test change. Approved.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 28, 2023
@carlossanlop carlossanlop merged commit 5ab27e3 into dotnet:release/8.0 Sep 28, 2023
15 of 20 checks passed
@radical radical deleted the fix-wbt-8 branch September 28, 2023 05:07
@radical radical mentioned this pull request Oct 3, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@ilonatommy ilonatommy Awaiting requested review from ilonatommy

@lewing lewing Awaiting requested review from lewing

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

@maraf maraf Awaiting requested review from maraf

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @carlossanlop