-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Bring back CopyOutputSymbolsToPublishDirectory #92369
Conversation
I accidentally removed this property from AOT compilation when adding support for Mac dsym bundles. This change re-enables support for suppressing debugging symbols in the output. Fixes #92188
…e.Publish.targets Co-authored-by: Michal Strehovský <[email protected]>
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #92315 to release/8.0 /cc @agocke Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
@agocke this is targeting Once the template is filled, please send an email to Tactics requesting approval. cc @jeffschwMSFT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 8.0.x
@carlossanlop This is ready to merge |
Backport of #92315 to release/8.0
/cc @agocke
Customer Impact
Fixes bug where Native AOT stopped respecting CopyOutputSymbolsToPublishDirectory.
Testing
Manual testing. Unit tests in the SDK have been written, but the SDK requires a new installer build in main, which we haven't gotten since the shift to 9.0.
Risk
Low. Isolated to Native AOT targets files.