Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ICU on Windows Server 2019 #72656

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Support ICU on Windows Server 2019 #72656

merged 2 commits into from
Jul 22, 2022

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 22, 2022

Fixes #62329

@ghost ghost assigned tarekgh Jul 22, 2022
@ghost
Copy link

ghost commented Jul 22, 2022

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #62329

Author: tarekgh
Assignees: -
Labels:

area-System.Globalization
Milestone: -

@tarekgh
Copy link
Member Author

tarekgh commented Jul 22, 2022

CC @janvorli @jkotas @eerhardt

@jkotas
Copy link
Member

jkotas commented Jul 22, 2022

Do we need a breaking change notification for this? This is going to change the globalization behavior for anybody deploying to Windows Server 2019.

@tarekgh
Copy link
Member Author

tarekgh commented Jul 22, 2022

Do we need a breaking change notification for this? This is going to change the globalization behavior for anybody deploying to Windows Server 2019.

Yes, I am going to file the breaking change issue and link it here.

@eerhardt
Copy link
Member

The issue also lists Windows Server 2016, but this PR doesn't mention it. Is that intentional?

@tarekgh
Copy link
Member Author

tarekgh commented Jul 22, 2022 •
edited
Loading

The issue also lists Windows Server 2016, but this PR doesn't mention it. Is that intentional?

I didn't mention Server 2016 because it is out of support, but I am testing with it to ensure it will work there too and I can mention it in the breaking change issue too.

@tarekgh tarekgh added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Jul 22, 2022
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jul 22, 2022
@tarekgh tarekgh added this to the 7.0.0 milestone Jul 22, 2022
@ghost
Copy link

ghost commented Jul 22, 2022 •
edited by tarekgh
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@tarekgh
Copy link
Member Author

tarekgh commented Jul 22, 2022

FYI, Server 2016 doesn't come with ICU libraries at all. You may look at History of changes to the ICU library in Windows for more info.

The change here is not going to affect Server 2016 at all. The only solution for users who are still using Server 2016 and want to use ICU is to use App Local ICU.

@tarekgh
Copy link
Member Author

tarekgh commented Jul 22, 2022 •
edited
Loading

I have filed the breaking change issue dotnet/docs#30319

@tarekgh tarekgh removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jul 22, 2022
@tarekgh tarekgh merged commit 7eaa6d1 into dotnet:main Jul 22, 2022
@tarekgh tarekgh deleted the SupportICUOnServer2019 branch July 22, 2022 23:10
@gewarren
Copy link
Contributor

Will this change be for RC1?

@tarekgh
Copy link
Member Author

tarekgh commented Jul 28, 2022

Will this change be for RC1?

Yes.

@karelz karelz mentioned this pull request Aug 7, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@jkotas jkotas jkotas approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Globalization breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

.NET 6 TimeZoneInfo.FindSystemTimeZoneById does not support IANA timezone ids on Windows Server 2016 & 2019
5 participants
@tarekgh @jkotas @eerhardt @gewarren @stephentoub