Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CEEInfo::getTypeForPrimitiveValueClass #71686

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Simplify CEEInfo::getTypeForPrimitiveValueClass #71686

merged 2 commits into from
Jul 6, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jul 5, 2022

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 5, 2022
@ghost ghost assigned jkotas Jul 5, 2022
@ghost
Copy link

ghost commented Jul 5, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: jkotas
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Jul 5, 2022

Simplified per #71633 (comment)

@jkotas jkotas requested review from EgorBo and jakobbotsch July 5, 2022 22:27
@jkotas
Copy link
Member Author

jkotas commented Jul 5, 2022

cc @MichalPetryka

jakobbotsch
jakobbotsch approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, I missed that there was still unaddressed feedback in that PR.

@jkotas
Copy link
Member Author

jkotas commented Jul 6, 2022

Test failure is #71684

@jkotas jkotas merged commit 206dccb into dotnet:main Jul 6, 2022
@jkotas jkotas deleted the getTypeForPrimitiveValueClass branch July 6, 2022 03:55
@runfoapp runfoapp bot mentioned this pull request Jul 6, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalPetryka MichalPetryka MichalPetryka approved these changes

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@EgorBo EgorBo Awaiting requested review from EgorBo

Assignees

@jkotas jkotas

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotas @jakobbotsch @MichalPetryka