Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SString::GetUTF8NoConvert to GetUTF8 that converts the SString #71101

Merged
merged 8 commits into from
Jun 23, 2022
Merged

Change SString::GetUTF8NoConvert to GetUTF8 that converts the SString #71101

merged 8 commits into from
Jun 23, 2022

Conversation

jkoritzinsky
Copy link
Member

This enables SString to get out of the UTF16 state and helps move us away from "SString's natural encoding is UTF16".

This is the first of multiple PRs based on work in #69748.

@jkoritzinsky
Change SString::GetUTF8NoConvert to GetUTF8 that converts the SString
00913ac 
This enables SString to get out of the UTF16 state and helps move us away from "SString's natural encoding is UTF16"
@jkoritzinsky jkoritzinsky requested a review from jkotas June 21, 2022 22:19
@ghost ghost assigned jkoritzinsky Jun 21, 2022
jkotas
jkotas approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

jkotas
jkotas reviewed Jun 21, 2022
View reviewed changes
src/coreclr/vm/gdbjit.cpp Outdated Show resolved Hide resolved
jkoritzinsky
jkoritzinsky commented Jun 21, 2022
View reviewed changes
Copy link
Member Author

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkotas same process applies for SetLiteral, correct?

src/coreclr/vm/coreassemblyspec.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/assemblynative.cpp Outdated Show resolved Hide resolved
jkotas
jkotas reviewed Jun 21, 2022
View reviewed changes
src/coreclr/vm/stubgen.cpp Outdated Show resolved Hide resolved
@jkotas
Copy link
Member

jkotas commented Jun 21, 2022

@jkotas same process applies for SetLiteral, correct?

Yep

@jkoritzinsky
Remove some stack scratch buffers that are unneeded now (as we can no…
3d8d510 
…w convert the SString itself and in some cases it was already in UTF8) and implement PR feedback.
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jun 22, 2022
View reviewed changes
src/coreclr/utilcode/sstring.cpp Outdated Show resolved Hide resolved
jkotas
jkotas reviewed Jun 22, 2022
View reviewed changes
src/coreclr/vm/assemblynative.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/assemblynative.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/assemblynative.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/coreassemblyspec.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/coreassemblyspec.cpp Outdated Show resolved Hide resolved
@jkoritzinsky
Copy link
Member Author

@jkotas any more feedback?

jkotas
jkotas approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jkotas jkotas merged commit d17741d into dotnet:main Jun 23, 2022
@jkoritzinsky jkoritzinsky deleted the sstring-getutf8 branch June 23, 2022 01:06
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoritzinsky @jkotas @AaronRobinsonMSFT