-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libraryimport src gen audit #69619
Merged
AaronRobinsonMSFT
merged 10 commits into
dotnet:main
from
AaronRobinsonMSFT:libraryimport_src_gen_audit
May 25, 2022
Merged
Libraryimport src gen audit #69619
AaronRobinsonMSFT
merged 10 commits into
dotnet:main
from
AaronRobinsonMSFT:libraryimport_src_gen_audit
May 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error when setting SetLastError - was ExactSpelling. Remove __ suffix from inner P/Invoke declaration.
AaronRobinsonMSFT
added
area-System.Runtime.InteropServices
source-generator
Indicates an issue with a source generator feature
labels
May 20, 2022
ghost
assigned AaronRobinsonMSFT
May 20, 2022
Tagging subscribers to this area: @dotnet/interop-contrib |
stephentoub
reviewed
May 20, 2022
...ies/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/ArrayMarshaller.cs
Show resolved
Hide resolved
stephentoub
reviewed
May 20, 2022
...System.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/GeneratedStatements.cs
Show resolved
Hide resolved
jkotas
reviewed
May 20, 2022
...ystem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/AnsiStringMarshaller.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 21, 2022
...ystem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/Utf8StringMarshaller.cs
Outdated
Show resolved
Hide resolved
@jkoritzinsky @elinor-fung - please take a look. |
elinor-fung
approved these changes
May 24, 2022
...ystem.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/VariableDeclarations.cs
Show resolved
Hide resolved
...ystem.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/VariableDeclarations.cs
Show resolved
Hide resolved
…erop.SourceGeneration/VariableDeclarations.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Runtime.InteropServices
source-generator
Indicates an issue with a source generator feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69541
Fixes #69532
Contributes to #69608 - Issue (5) and issues (2), (4), and (8) under the Style section.