Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraryimport src gen audit #69619

Merged

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented May 20, 2022

Fixes #69541
Fixes #69532
Contributes to #69608 - Issue (5) and issues (2), (4), and (8) under the Style section.

Fix error when setting SetLastError - was ExactSpelling.
Remove __ suffix from inner P/Invoke declaration.
@AaronRobinsonMSFT AaronRobinsonMSFT added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels May 20, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 7.0.0 milestone May 20, 2022
@ghost
Copy link

ghost commented May 20, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #69541
Fixes #69532
Contributes to #69608

  • Issues (2) and (8) under the Style section.
Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: 7.0.0

@AaronRobinsonMSFT
Copy link
Member Author

@jkoritzinsky @elinor-fung - please take a look.

…erop.SourceGeneration/VariableDeclarations.cs
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 0df1214 into dotnet:main May 25, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the libraryimport_src_gen_audit branch May 25, 2022 03:49
@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
4 participants