Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requested version to hostfxr_resolve_sdk2 #68355

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Apr 21, 2022

Add hostfxr_resolve_sdk2_result_key_t::requested_version for indicating the SDK version requested (if any). The callback will be invoked with that key only if there was a version specified.

@ghost
Copy link

ghost commented Apr 21, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Add hostfxr_resolve_sdk2_result_key_t::requested_version for indicating the SDK version requested (if any).

Author: elinor-fung
Assignees: -
Labels:

area-Host

Milestone: -

@elinor-fung elinor-fung reopened this Apr 22, 2022
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/native/corehost/fxr/hostfxr.cpp Show resolved Hide resolved
src/native/corehost/fxr/sdk_resolver.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@elinor-fung
Copy link
Member Author

Failure is #67761

@elinor-fung elinor-fung merged commit 3f4ac7f into dotnet:main Apr 25, 2022
@elinor-fung elinor-fung deleted the sdkRequestedVersion branch April 25, 2022 17:27
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants