Vectorize System.Collections.Generic.Dictionary #110701
Draft
+765
−691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upt our internal state
Various cleanups
…rehash, 124 is closer
kg
added
NO-MERGE
|
Tagging subscribers to this area: @dotnet/area-system-collections |
|
Looks like scalar suffix search is broken somehow, but the vectorized suffix search appears to work on wasm and arm64. |
|
PartitionedRateLimiterTests.Create_PassedInEqualityComparerIsUsed is asserting that we don't call GetHashCode when TryGetValue is invoked on an empty Dictionary. The other assertions in it will potentially break too since vectorized dictionary doesn't cache full hashcodes. |
This was referenced Dec 14, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the libraries tests still fail on my machine even on a fresh checkout of main, so this is to see how many regressions this actually produces.
Locally at present System.Collections.Tests has a total of 4 failures (in the concurrent modification detection, because the old way of corrupting the dictionary doesn't work anymore.)