Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling event tracing #110622

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cshung
Copy link
Member

@cshung cshung commented Dec 11, 2024

These fixes make it possible to turn off FEATURE_EVENT_TRACE during build.

Note: the actual disabling of FEATURE_EVENT_TRACE is just a test, do NOT merge that.

@janvorli

@cshung cshung added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-VM-coreclr labels Dec 11, 2024
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@lateralusX
Copy link
Member

We had a similar build issue when bringing up Android runtime builds on CoreCLR, at one point it disabled the FEATURE_EVENT_TRACE using:

<_CoreClrBuildArg Include="-cmakeargs -DFEATURE_EVENT_TRACE=0"/>

and that caused the following error:

C:\git\runtime\src\coreclr\inc\profilepriv.h(388,34): error C2061: syntax error: identifier 'EventPipeProvider' [C:\git\runtime\artifacts\obj\coreclr\windows.x64.Debug\ide\debug\daccess\daccess.vcxproj]

So looks like this PR will fix that issue!

One thought, looks like the profilepriv.h introduce the typedef typedef struct _EventPipeProvider EventPipeProvider using a different define, FEATURE_PERF_TRACING, compared to what's being used in eventpipeadaptertypes.h, FEATURE_PERFTRACING, intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-VM-coreclr NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants