-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support disabling event tracing #110622
base: main
Are you sure you want to change the base?
Support disabling event tracing #110622
Conversation
Tagging subscribers to this area: @mangod9 |
80f08f1
to
377fc28
Compare
This reverts commit 377fc28.
We had a similar build issue when bringing up Android runtime builds on CoreCLR, at one point it disabled the FEATURE_EVENT_TRACE using: <_CoreClrBuildArg Include="-cmakeargs -DFEATURE_EVENT_TRACE=0"/> and that caused the following error: C:\git\runtime\src\coreclr\inc\profilepriv.h(388,34): error C2061: syntax error: identifier 'EventPipeProvider' [C:\git\runtime\artifacts\obj\coreclr\windows.x64.Debug\ide\debug\daccess\daccess.vcxproj] So looks like this PR will fix that issue! One thought, looks like the profilepriv.h introduce the typedef |
These fixes make it possible to turn off
FEATURE_EVENT_TRACE
during build.Note: the actual disabling of
FEATURE_EVENT_TRACE
is just a test, do NOT merge that.@janvorli