[release/9.0] Add DefaultMemberAttribute to Test.CoreLib #108258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested a review
from MichalStrehovsky
as a code owner
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jeffschwMSFT
approved these changes
Oct 2, 2024
|
@AlekseyTs could you sign off on the backport please? |
|
still waiting on a code review to merge. please also take a look at the pr failures. |
AlekseyTs
approved these changes
Oct 10, 2024
This was referenced Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108236 to release/9.0
/cc @MichalStrehovsky
Tell mode: This only affects test code. Roslyn is planning to ship a breaking change that will break the our builds if this is not picked up (see #107953 (comment)).