[release/9.0] Update field references in property accessors
#108222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested a review
from MichalStrehovsky
as a code owner
dotnet-issue-labeler
bot
added
the
needs-area-label
This was referenced Sep 25, 2024
Open
teo-tsirpanis
added
area-Meta
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-meta |
|
@MichalStrehovsky @cston is this ready for review and inclusion in 9.0 release? Does this backport include all changes made in main, in #108219? Source-build is failing (in stage 2) with the following errors - are all of those fixed with these pending changes: dotnet/source-build#4639 |
This change should include all the changes from #108219, and it looks like the errors above should be fixed with these changes. Note, there were some additional errors in main that were not fixed in #108219, but do not appear in the errors above: see follow-up PRs #108225, #108413. |
This was referenced Oct 2, 2024
|
@cston, @stephentoub who owns this backport? This is blocking source-build stage 2 builds and is needed for 9.0 release. |
@cston will be updating it with the additional PRs / commits from main. |
* Update field references in property accessors * Update field references * Use @ * Rename field --------- Co-authored-by: Stephen Toub <[email protected]>
stephentoub
approved these changes
Oct 10, 2024
stephentoub
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108219, #108225, and #108413 to release/9.0
Rename or qualify
fieldreferences in property accessors to avoid conflict withfieldkeyword in C# compiler preview.With the .NET 9 C# compiler, when compiling with
-langversion:preview,fieldreferences within property accessors are treated as referring to a synthesized backing field for the property rather than to another symbol namedfieldthat may be in scope.The change here is to rename existing fields and locals to retain the original intent.
/cc @stephentoub @cston
Customer Impact
The issue was found by compiling dotnet/runtime with the updated .NET 9 C# compiler.
No expected customer impact.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
Low risk. The change is a rename of locals and fields only.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.