[browser][MT] longer timeout for VFS heavy tests #105258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
maraf
approved these changes
Jul 22, 2024
This was referenced Jul 22, 2024
akoeplinger
reviewed
Jul 23, 2024
| @@ -16,6 +16,11 @@ | |||
| <DefineConstants>$(DefineConstants);TARGET_BROWSER</DefineConstants> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(TargetOS)' == 'browser' and '$(WasmEnableThreads)' == 'true'"> | |||
| <!-- VSF is emulated on the UI thread and all calls are slow because they are marshaled --> | |||
| @@ -243,6 +243,9 @@ | |||
| <Command>$(HelixCommand)</Command> | |||
| <Timeout>$(_workItemTimeout)</Timeout> | |||
| <Timeout Condition="'$(Scenario)' == 'WasmTestOnNodeJS' and '%(FileName)' == 'System.Net.Http.Functional.Tests'">01:20:00</Timeout> | |||
| <!-- VSF is emulated on the UI thread and all calls are slow because they are marshaled --> | |||
| <Timeout Condition="'%(FileName)' == 'System.IO.FileSystem.Tests' and '$(WasmEnableThreads)' == 'true'">01:20:00</Timeout> | |||
| <Timeout Condition="'%(FileName)' == 'System.Private.Xml.Tests' and '$(WasmEnableThreads)' == 'true'">01:20:00</Timeout> | |||
There was a problem hiding this comment.
curious why we need this here, is the one in the .csproj not enough?
There was a problem hiding this comment.
they are separate msbuild run. This runs once for all assemblies.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longer timeout for MT
because VFS in is in the UI thread and it's slower
Contributes to #103524
Contributes to #103623