Disable the AndroidLinkResources optimization #7038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
platform/android 🤖
p/0
jonathanpeppers
approved these changes
May 11, 2022
Redth
approved these changes
May 11, 2022
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Sep 13, 2022
) Fixes: #7194 Context: dotnet/maui#7038 The initial version of `$(AndroidLinkResources)` (9e6ce03) was too broad in its removal of Resource classes and fields. Certain fields such as `Styleable` arrays were not called using the IL `stsfld` opcode. As a result they could not be easily replaced with constant usage. However, the linker removed *all* the fields from the `Resource` nested types. This would result in the following error at runtime: System.BadImageFormatException: 'Could not resolve field token 0x0400000b' This was because the `int[]` fields were removed as part of the linking process. Fix this by leaving the `int[]` fields in the `Resource` nested types instead of removing them. We can still remove all the other `int` fields. We now also need to fix up the `Resource` nested type constructors to replace the `int` field access with the constant values like we do for the rest of the app. This was not required previously because these constructors were removed, but now we have to keep them because the static array initialization takes place in these constructors.
Eilon
added
the
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Disable the optimization as it causes a crash with libraries that use the resources - such as SkiaSharp. This could be any library that has Android controls defined in C# and use android styles.
However, if an app is not using any controls like this, they can still manually enable this feature and get all the wins!
Issues Fixed
Related to #7037