Don't try to print predefined ranges contents in debug #7898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
changed the title
TIHan
reviewed
Nov 22, 2019
| @@ -200,6 +200,10 @@ let fileOfFileIndex idx = fileIndexTable.IndexToFile idx | |||
|
|
|||
| let mkPos l c = pos (l, c) | |||
|
|
|||
| let unknownFileName = "unknown" | |||
There was a problem hiding this comment.
This is fine. Just for future reference, I would make these [<Literal>] but we still have a bug for fsi/signature files that prevents using [<Literal>] in a reasonable way. Therefore, we can't make these literal yet.
There was a problem hiding this comment.
Yes, I tried to make it [<Literal>] at first and had to report the bug instead in #7897.
TIHan
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rangetype hasDebuggerDisplaydefined to show file contents when possible.It shouldn't, however, try to do this for predefined ranges, like
rangeStartuporrange0as it fails to find such file:This PR makes it print the predefined ranges file names instead:
