-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug formatting #7196
debug formatting #7196
Conversation
Just to check, this doesn't prevent inspection of these structures if it's intentional? |
That's right, it's just the debug text shown next to the value, you can still expand |
BTW here's another
|
These dang semicolons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotnet/project-system
why did you not use the debuggerviewattribute to change the debugger output, since that is what it is for?
This PR appears to be almost all reformatting, with a couple of overrides added to change the debugging output. Do you think they should be split into a reformatting pr and a debug formatting pr?
Because some other formatting (e.g. F# structured formatting) ends up using ToString, and we may as well just do this formatting everywhere that strings may come out - we never want to format these records as strings, it is arbitrarily expensive and impossible to read.
No, I don't think it needs to be split, it's ok to combine a bit of reformatting with other changes that improve the codebase without changing external functionality. |
* debug formatting * whitespace * whitespace * Update DetupleArgs.fs
The compiler uses various records, and the default ToString fromatting used by a typical debugger ends up formatting these, which can lead to very slow debugging even when not inspecting these structures