Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe (64-bit) the default to launch in VS #6223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
… (64-bit) the default to launch in VS dotnet#6223
|
Okay I think this makes sense. Retain a 32bit desktop FSI for back-compatability, but migrate VS forward to the 64 bit build. The only thing that I am unsure about is that fsi.exe "the good name" gets to be the 32 bit version ... the non default version. This would mean that VS scripts that run in 64 bit, would have a hard time on the command line, unless someone knew to use the FsiAnyCPU.exe. Regardless the above is still better than silently upgrading fsi.exe to Any CPU and retaining fsi anycpu as exactly the same thing to confuse folks. Anyway this puts us back to where we were in dev15.9 except for updating FSI to 64 bit where it can be. Kevin |
cartermp
approved these changes
Feb 12, 2019
dsyme
added a commit
to dsyme/fsharp
that referenced
this pull request
Feb 28, 2019
… (64-bit) the default to launch in VS dotnet#6223
dsyme
added a commit
that referenced
this pull request
Mar 1, 2019
* Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe (64-bit) the default to launch in VS #6223 * make fsc.exe 32-bit for compat * make fsc.exe 32-bit for compat * improve diagnostics * fix tests * fix determinism
dsyme
added a commit
that referenced
this pull request
Mar 2, 2019
* process large expressions systematically * add test cases * update tests * Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe (64-bit) the default to launch in VS #6223 * make fsc.exe 32-bit for compat * make fsc.exe 32-bit for compat * fix build * fix build * ramp up max testing * correct optimization of linear matches * improve diagnostics * fix tests * tests only on .NET Framework for now * fix determinism
dsyme
pushed a commit
that referenced
this pull request
Mar 2, 2019
* Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe (64-bit) the default to launch in VS #6223 * make fsc.exe 32-bit for compat * make fsc.exe 32-bit for compat * improve diagnostics * fix tests * fix determinism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6219
In addition, for dev16.0 I think it would make sense to make 64-bit the default when launching VS in Visual Studio for dev16.0. For example ML.NET only works with 64-bit, and F# Interactive in NET Core is 64-bit always. This PR makes this change too.