Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve workflows #6040

Merged
merged 6 commits into from
Dec 21, 2018
Merged

Improve workflows #6040

merged 6 commits into from
Dec 21, 2018

Conversation

KevinRansom
Copy link
Member

Improve some of the build workflows in the new build.

  1. Adds ngen to build for desktop and ngen builds of fsi.exe and fsc.exe, when run with administrator privileges
  2. Correct the check for existence of proto compiler before rebuilding it. (Was rebuilding always)
  3. Build proto. Once again only rebuilds the proto compiler not the coreclr and desktop compilers
  4. Ensure that Proto build only builds the desktop version of the proto compiler.

@KevinRansom KevinRansom requested a review from brettfo December 20, 2018 09:10
brettfo
brettfo requested changes Dec 20, 2018
View reviewed changes
src/fsharp/FSharp.Compiler.nuget/Directory.Build.targets Outdated Show resolved Hide resolved
src/fsharp/fsi/fsi.fsproj Outdated Show resolved Hide resolved
build/targets/NgenOrCrossGen.targets Outdated Show resolved Hide resolved
build/targets/NgenOrCrossGen.targets Outdated Show resolved Hide resolved
src/fsharp/fsc/fsc.fsproj Outdated Show resolved Hide resolved
@KevinRansom KevinRansom force-pushed the ImproveWorkflows branch 3 times, most recently from ce9ac12 to ccf2cf2 Compare December 21, 2018 05:23
@KevinRansom KevinRansom merged commit 6bed7c4 into dotnet:master Dec 21, 2018
@cartermp cartermp mentioned this pull request Dec 21, 2018
Closed
@KevinRansom KevinRansom deleted the ImproveWorkflows branch December 27, 2018 20:00
@cartermp cartermp mentioned this pull request Jan 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettfo brettfo brettfo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinRansom @brettfo