Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jaro-Winkler distance to give better predictions - fixes #1863 #1945

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

Rickasaurus
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Dec 5, 2016

Hi @Rickasaurus, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@forki
Copy link
Contributor

forki commented Dec 5, 2016

so happy to see this PR!

awesome

@forki
Copy link
Contributor

forki commented Dec 5, 2016

@Rickasaurus after you signed the CLA from https://cla.microsoft.com just close and reopen this PR. then the bot should reavaluate your CLA status and show the approriate status.

@forki
Copy link
Contributor

forki commented Dec 5, 2016

Rick just said CLA is signed

@cartermp
Copy link
Contributor

cartermp commented Dec 5, 2016

@martinwoodward looks like @Rickasaurus signed the CLI a while ago, but the bot isn't picking it up. Any insights?

@martinwoodward
Copy link
Member

I see the CLA was approved just over an hour ago - not sure why it took so long to come back sorry or why the bot hasn't picked it up. I'll email the CLA folks to ask but in the meantime I've manually labelled as CLA Signed.

@forki
Copy link
Contributor

forki commented Dec 5, 2016

In other words: it was already approved and CLA is signed. So @dsyme @KevinRansom please merge it ;-)

Copy link
Contributor

@dsyme dsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see so many tests

@KevinRansom KevinRansom merged commit 037bd0d into dotnet:master Dec 6, 2016
@forki forki deleted the jarowinkler branch December 6, 2016 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants