Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VS2017.11 dependencies #17144

Merged
merged 7 commits into from
May 16, 2024
Merged

Update VS2017.11 dependencies #17144

merged 7 commits into from
May 16, 2024

Conversation

KevinRansom
Copy link
Member

Update dependencies for VS2017.11 - AbstractLanguageService<> has changed it's contract so a few updates were needed.

/cc @vzarytovskii

@KevinRansom KevinRansom requested a review from a team as a code owner May 14, 2024 23:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansom KevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label May 15, 2024
@KevinRansom KevinRansom requested a review from a team as a code owner May 15, 2024 09:42
@vzarytovskii
Copy link
Member

vzarytovskii commented May 15, 2024 •
edited
Loading

As soon as @dotnet/source-build-internal approve/request changes (i.e. msbuild via darc, please see comment above), we should merge and insert it.
My ask is to allow us to have msbuild in SourceBuildPrebuiltBaseline.xml, if possible, and then, after bug is fixed, I will make it right via darc.

@MichaelSimons MichaelSimons mentioned this pull request May 15, 2024
Merged
@KevinRansom KevinRansom enabled auto-merge (squash) May 16, 2024 01:31
@KevinRansom KevinRansom merged commit b4ebffd into dotnet:release/dev17.11 May 16, 2024
32 checks passed
This was referenced May 17, 2024
Closed
Closed
@KevinRansom KevinRansom deleted the VS2017.11 branch June 25, 2024 00:39
@brianrourkeboll brianrourkeboll mentioned this pull request Jul 8, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii left review comments

@T-Gro T-Gro T-Gro approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KevinRansom @vzarytovskii @MichaelSimons @T-Gro