-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable realsig #17104
Re-enable realsig #17104
Conversation
|
69acf28
to
ec6f50f
Compare
ec6f50f
to
02fbcbf
Compare
//cc @psfinaki @vzarytovskii @T-Gro This is ready |
Do I get it right that the surface area is now the same with both realsig on and off? If so, this hack should be removed. |
Removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kevin for handling this.
Realsig got disabled by a merge back from release/dev10.
The recent merge of the Equals() optimization identified an issue with DU codegen. There was an issue with how DU code generation worked for DU type members for realsig-. It always generates members with the scope of the DU case. The Equals() optimization applied to a public DU with internal cases was generated with an internal scope rather than public visibility.
This change: