Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable realsig #17104

Merged
merged 4 commits into from
May 7, 2024
Merged

Re-enable realsig #17104

merged 4 commits into from
May 7, 2024

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Apr 29, 2024

Realsig got disabled by a merge back from release/dev10.

The recent merge of the Equals() optimization identified an issue with DU codegen. There was an issue with how DU code generation worked for DU type members for realsig-. It always generates members with the scope of the DU case. The Equals() optimization applied to a public DU with internal cases was generated with an internal scope rather than public visibility.

This change:

  1. Ensures that Equals is produced with the scope of the DU rather than the scope of the case.
  2. Updates surface area baseline to include corrected DUs
  3. Adds regression tests that verify codegen and visibility for realsig+ and realsig-

@KevinRansom KevinRansom requested a review from a team as a code owner April 29, 2024 20:57
Copy link
Contributor

github-actions bot commented Apr 29, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansom KevinRansom force-pushed the realenablerealsig branch 2 times, most recently from 69acf28 to ec6f50f Compare May 4, 2024 00:02
@KevinRansom KevinRansom force-pushed the realenablerealsig branch from ec6f50f to 02fbcbf Compare May 4, 2024 00:03
@KevinRansom KevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label May 4, 2024
@KevinRansom
Copy link
Member Author

//cc @psfinaki @vzarytovskii @T-Gro

This is ready

@psfinaki
Copy link
Member

psfinaki commented May 6, 2024

Do I get it right that the surface area is now the same with both realsig on and off?

If so, this hack should be removed.

@KevinRansom
Copy link
Member Author

Do I get it right that the surface area is now the same with both realsig on and off?

If so, this hack should be removed.

Removed

@psfinaki psfinaki enabled auto-merge (squash) May 7, 2024 08:48
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin for handling this.

@psfinaki psfinaki merged commit 83c8d9a into dotnet:main May 7, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants