Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to release/dev17.10 #16959

Merged
merged 11 commits into from
Mar 28, 2024
Merged

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from main into release/dev17.10.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-release/dev17.10
git reset --hard upstream/release/dev17.10
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-release/dev17.10 --force

auduchinok and others added 10 commits March 22, 2024 20:57
Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24170.6 -> To Version 8.0.0-beta.24172.5

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Unskip a few tests

* another one
* add test case showing a false positive with yield!

* add missing case in IsAppInLambdaBody that can happen with yield!

* add release notes entry

* update PR number

* only bind to what we are interested in

* add test expecting a warning for yield! in a list comprehension

* add test case using yield! in a custom CE that overflows the stack
* Minor README update about proto

It's Bootstrap actually.

* Update DEVGUIDE.md

Co-authored-by: Vlad Zarytovskii <[email protected]>

* Update DEVGUIDE.md

---------

Co-authored-by: Vlad Zarytovskii <[email protected]>
…ent (#16942)

* Make it easy to bench preview against current
…ests (#16955)

* Exclude compiler service benchmark from VMR build when not building tests

* remove Z

---------

Co-authored-by: Petr <[email protected]>
…326.8 (#16957)

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24172.5 -> To Version 8.0.0-beta.24176.8

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-bot dotnet-bot force-pushed the merges/main-to-release/dev17.10 branch from d6773a3 to ee46275 Compare March 28, 2024 00:01
@dotnet-bot dotnet-bot requested a review from a team as a code owner March 28, 2024 00:01
Copy link
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md No current pull request URL (#16959) found, please consider adding it

1 similar comment
Copy link
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md No current pull request URL (#16959) found, please consider adding it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants