Update docs.microsoft.com to learn.microsoft.com. #14774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarfgp
approved these changes
Feb 21, 2023
abonie
reviewed
Feb 21, 2023
abonie
reviewed
Feb 21, 2023
|
Can you please also scrub 'en-us' from all docs links that are updated in this PR? |
abonie
approved these changes
Feb 21, 2023
KevinRansom
requested changes
Feb 21, 2023
There was a problem hiding this comment.
This looks good, however, per @baronfels request.
I believe if you remove the en-us from the urls, then it will go to localized versions of the documention depending on the browsers configuration.
E.g:
https://learn.microsoft.com/azure/devops/pipelines/yaml-schema?view=vsts&tabs=schema#job
On my browser goes to: https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=vsts&tabs=schema#job
So it would probably be preferable if we didn't make everyone read the us version of the docs.
kant2002
pushed a commit
to kant2002/fsharp
that referenced
this pull request
Apr 1, 2023
* Update docs.microsoft.com to learn.microsoft.com. * Correct links in FSharp.Core. * Scrub en-us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of fsprojects/FSharp.Formatting#794, I want to update all documentation links from
https://docs.microsoft.com/tohttps://learn.microsoft.com/.