Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crossgen #1197

Closed
wants to merge 24 commits into from
Closed

Crossgen #1197

wants to merge 24 commits into from

Conversation

KevinRansom
Copy link
Member

More preparation for cross platform build.

  1. Remove Proto Projects.
  2. Build Proto from Product projects - targeting coreclr
  3. Remove unused PlatformTargets / some Silverlight stuff from targets file
  4. Publish proto and lkg using dotnet publish
  5. Crossgen the proto compiler

KevinRansom added 15 commits May 2, 2016 20:18
@KevinRansom
Builds proto
af62c57
@KevinRansom
temporary
5f72b86
@KevinRansom
Build proto to coreclr
176d1db
@KevinRansom
publish lkg and proto correctly
4512415
@KevinRansom
Merge branch 'master' of https://github.com/Microsoft/visualfsharp in…
b4253f6 
…to saved
@KevinRansom
Build Proto with coreclr
f771a13
@KevinRansom
1. Remove proto projects, 2. Build proto to target coreclr with regul…
13135a4 
…ar F# build projects, 3 Update fsharp-proto-build.proj, 4. remove a flaky test, tweak host.netcore nuget package.
@KevinRansom
Merge master
dba80e9
@KevinRansom
Merge branch 'master' into crossgen
2ef10dd
@KevinRansom
Update from master
bfe9103
@KevinRansom
Merge branch 'master' of https://github.com/Microsoft/visualfsharp in…
ef6b1b6 
…to crossgen
@KevinRansom
Proto project.json
63278af
@KevinRansom
nunit cambridge test was only looking for dev15 version of msbuild be…
41f903f 
…fore falling back to framework. Ensure it also looks for VS2015
@KevinRansom
1. Remove proto projects. 2. Build proto to coreclr. 3. crossgen prot…
edf7fd7 
…o assemblies
@KevinRansom
merge master
b923172
dsyme
dsyme reviewed May 18, 2016
View reviewed changes
src/absil/ilsupp.fs
@@ -748,110 +756,6 @@ let linkNativeResources (unlinkedResources:byte[] list) (ulLinkedResourceBaseRV

// return the buffer
pResBuffer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead code?

@dsyme
Copy link
Contributor

dsyme commented May 18, 2016 •
edited
Loading

Could you adjust DEVGUIDE.md to describe how the build works please? Thanks

There are various bits and pieces I don't understand here. I'll take another look when the lights are green.

@KevinRansom
Copy link
Member Author

@dsyme ...
I will add a switch too build proto for windows, we still don't need the old project files for that. However, the coreclr compiler does need to be every bit as functional and fast as the desktop compiler. So we shouldn't really consider this as cutting us off from the "Good Windows Desktop developer world". The desktop clr build just makes debugging and testing a bit more convenient right now.

We do need the proto to build on coreclr to ensure that:

  1. We can use the coreclr build of FSC to run a large application
  2. In order to build on OSX and Linux

Kevin

@dsyme
Copy link
Contributor

dsyme commented Jun 6, 2016

@KevinRansom super

@KevinRansom KevinRansom deleted the crossgen branch September 16, 2016 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KevinRansom @dsyme @smoothdeveloper @enricosada @matthid @msftclas