Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add allowCompilationErrors option #8554

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Mar 26, 2023

Add an allowCompilationErrors option to report compilation errors as warnings. Enabling this option may address some edge use cases, but could also result in crashes or undefined behaviors.

fixes #8429

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Mar 26, 2023
@yufeih yufeih force-pushed the allow-compilation-errors branch from a068a5d to b7f6abe Compare March 26, 2023 02:14
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4973f9a). Click here to learn what that means.
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8554   +/-   ##
=======================================
  Coverage        ?   75.29%           
=======================================
  Files           ?      650           
  Lines           ?    23972           
  Branches        ?        0           
=======================================
  Hits            ?    18050           
  Misses          ?     5922           
  Partials        ?        0           
Impacted Files Coverage Δ
...de.Dotnet/ExtractMetadata/ExtractMetadataWorker.cs 75.47% <75.00%> (ø)
...rc/Microsoft.DocAsCode.Dotnet/CompilationHelper.cs 87.91% <100.00%> (ø)
src/Microsoft.DocAsCode.Dotnet/DotnetApiCatalog.cs 72.88% <100.00%> (ø)
...de.Dotnet/ExtractMetadata/ExtractMetadataConfig.cs 100.00% <100.00%> (ø)
...crosoft.DocAsCode.Dotnet/MetadataJsonItemConfig.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit c69cb7c into main Mar 26, 2023
@yufeih yufeih deleted the allow-compilation-errors branch March 26, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error CS0234 when Upgrading from 2.61.0 to 2.62.xx
1 participant