Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve langword to URLs #8550

Merged
merged 3 commits into from
Mar 25, 2023
Merged

feat: resolve langword to URLs #8550

merged 3 commits into from
Mar 25, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Mar 25, 2023

Resolve langword to URLs as described in https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/

When unresolved, render as <c>langword</c>

Fixes #7625

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Mar 25, 2023
@yufeih yufeih merged commit e870adf into main Mar 25, 2023
@yufeih yufeih deleted the langword branch March 25, 2023 11:37
private static ReadOnlySpan<byte> CSharpLangwords =>
"""
{
"abstract": "https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/abstract",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should not have en-us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET "langword" doesn't work
2 participants