Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: drop dfm markdown engine #8537

Merged
merged 2 commits into from
Mar 22, 2023
Merged

BREAKING CHANGE: drop dfm markdown engine #8537

merged 2 commits into from
Mar 22, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Mar 20, 2023

Drop markdownlite and DFM. Make markdig the only supported markdown engine in docfx. Remove the markdownEngineName options.

@yufeih yufeih added the breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note label Mar 20, 2023
@yufeih yufeih force-pushed the feature/drop-dfm branch from d924cbf to d8b0369 Compare March 20, 2023 11:53
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 89.47% and project coverage change: -1.16 ⚠️

Comparison is base (b70661c) 76.30% compared to head (d8b0369) 75.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8537      +/-   ##
==========================================
- Coverage   76.30%   75.14%   -1.16%     
==========================================
  Files         858      643     -215     
  Lines       30638    23559    -7079     
==========================================
- Hits        23378    17704    -5674     
+ Misses       7260     5855    -1405     
Impacted Files Coverage Δ
.../Microsoft.DocAsCode.App/Config/BuildJsonConfig.cs 88.09% <ø> (-0.28%) ⬇️
...ft.DocAsCode.App/Helpers/DocumentBuilderWrapper.cs 77.04% <ø> (+0.16%) ⬆️
.../Microsoft.DocAsCode.App/Helpers/MetadataMerger.cs 0.00% <0.00%> (ø)
....DocAsCode.Build.Engine/DocumentBuildParameters.cs 100.00% <ø> (ø)
...Code.Build.SchemaDriven/ApplyOverwriteFragments.cs 84.21% <ø> (-0.68%) ⬇️
src/docfx/Models/BuildCommandOptions.cs 97.05% <ø> (-0.09%) ⬇️
src/docfx/SubCommands/BuildCommand.cs 66.30% <ø> (+0.17%) ⬆️
...rc/Microsoft.DocAsCode.Build.Engine/XrefDetails.cs 91.42% <85.71%> (ø)
...e.Build.ConceptualDocuments/HtmlDocumentUtility.cs 94.11% <100.00%> (ø)
...icrosoft.DocAsCode.Build.Engine/DocumentBuilder.cs 77.77% <100.00%> (+2.64%) ⬆️
... and 2 more

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih marked this pull request as ready for review March 21, 2023 09:19
@yufeih yufeih merged commit db3da82 into main Mar 22, 2023
@yufeih yufeih deleted the feature/drop-dfm branch March 22, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant