Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DiagnosticsClient.ApplyStartupHook public #5086

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+23 −2
Open

Make DiagnosticsClient.ApplyStartupHook public #5086

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03d9833
Make DiagnosticsClient.ApplyStartupHook public
xoofx Dec 5, 2024
29e0161
Don't check if assembly exists locally
xoofx Dec 5, 2024
bb7c6cb
Rermove checks for .NET 8
xoofx Dec 5, 2024
36f377f
Remove invalid XML docs
xoofx Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,15 +332,36 @@ internal async Task<Dictionary<string, string>> GetProcessEnvironmentAsync(Cance
return await helper.ReadEnvironmentAsync(response.Continuation, token).ConfigureAwait(false);
}

internal void ApplyStartupHook(string startupHookPath)
/// <summary>
/// Loads the specified assembly with a StartupHook in the target process.
/// </summary>
/// <param name="startupHookPath">The path to the assembly containing the StartupHook.</param>
/// <exception cref="ArgumentNullException">Thrown when <paramref name="startupHookPath"/> is null or empty.</exception>
public void ApplyStartupHook(string startupHookPath)
{
if (string.IsNullOrEmpty(startupHookPath))
{
throw new ArgumentNullException(nameof(startupHookPath));
}

IpcMessage message = CreateApplyStartupHookMessage(startupHookPath);
IpcMessage response = IpcClient.SendMessage(_endpoint, message);
ValidateResponseMessage(response, nameof(ApplyStartupHook));
}

internal async Task ApplyStartupHookAsync(string startupHookPath, CancellationToken token)
/// <summary>
/// Loads the specified assembly with a StartupHook in the target process.
/// </summary>
/// <param name="startupHookPath">The path to the assembly containing the StartupHook.</param>
/// <param name="token">The token to monitor for cancellation requests.</param>
/// <exception cref="ArgumentNullException">Thrown when <paramref name="startupHookPath"/> is null or empty.</exception>
public async Task ApplyStartupHookAsync(string startupHookPath, CancellationToken token)
{
if (string.IsNullOrEmpty(startupHookPath))
{
throw new ArgumentNullException(nameof(startupHookPath));
}

IpcMessage message = CreateApplyStartupHookMessage(startupHookPath);
IpcMessage response = await IpcClient.SendMessageAsync(_endpoint, message, token).ConfigureAwait(false);
ValidateResponseMessage(response, nameof(ApplyStartupHookAsync));
Expand Down