Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] [Blazor] Fix template nav menu styling #58277

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 7, 2024

Backport of #58245 to release/9.0

[Blazor] Fix template nav menu styling

Addresses an issue where navigation menu link padding was incorrect in each Blazor template.

Description

The problem appeared after upgrading to the latest available version of Bootstrap (5.3.3). The fix is to add the nav CSS class to the navigation menu container element.

Before

image

After

image

Fixes #58214

Customer Impact

Without this fix, each newly-created Blazor app would have incorrect styling on the navigation menu. Customers would have to manually correct the CSS in their app after creating a new Blazor project.

Regression?

  • Yes
  • No

Regressed from .NET 9 RC1

Risk

  • High
  • Medium
  • Low

The fix only adjusts the CSS class of the navigation menu. Other template functionality remains unchanged.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@github-actions github-actions bot requested a review from a team as a code owner October 7, 2024 20:47
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Oct 7, 2024
@MackinnonBuck MackinnonBuck added ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. area-blazor Includes: Blazor, Razor Components and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Oct 7, 2024
@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. labels Oct 8, 2024
@wtgodbe wtgodbe merged commit 1068ef8 into release/9.0 Oct 8, 2024
25 checks passed
@wtgodbe wtgodbe deleted the backport/pr-58245-to-release/9.0 branch October 8, 2024 20:45
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants