Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Mark API from 9 as shipped #58060

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Sep 24, 2024

This should be ported to main when we ship RTM on November 12

@wtgodbe wtgodbe added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Sep 24, 2024
@wtgodbe wtgodbe mentioned this pull request Sep 24, 2024
10 tasks
@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 24, 2024

Part of #57461

@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 24, 2024

Code Check failure is expected

@wtgodbe wtgodbe merged commit f4895d9 into release/9.0 Sep 26, 2024
22 of 25 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/MarkShipped9.0 branch September 26, 2024 16:52
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.0 milestone Sep 26, 2024
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 12, 2024

/backport to main

Copy link
Contributor

Started backporting to main: https://github.com/dotnet/aspnetcore/actions/runs/11804728372

Copy link
Contributor

@wtgodbe backporting to main failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Mark API from 9 as shipped
Using index info to reconstruct a base tree...
M	src/Http/Http.Abstractions/src/PublicAPI.Unshipped.txt
M	src/Http/Http.Results/src/PublicAPI.Unshipped.txt
M	src/Mvc/Mvc.Core/src/PublicAPI.Unshipped.txt
Falling back to patching base and 3-way merge...
Auto-merging src/Mvc/Mvc.Core/src/PublicAPI.Unshipped.txt
CONFLICT (content): Merge conflict in src/Mvc/Mvc.Core/src/PublicAPI.Unshipped.txt
Auto-merging src/Http/Http.Results/src/PublicAPI.Unshipped.txt
CONFLICT (content): Merge conflict in src/Http/Http.Results/src/PublicAPI.Unshipped.txt
Auto-merging src/Http/Http.Abstractions/src/PublicAPI.Unshipped.txt
CONFLICT (content): Merge conflict in src/Http/Http.Abstractions/src/PublicAPI.Unshipped.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Mark API from 9 as shipped
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

@wtgodbe an error occurred while backporting to main, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants