Fix up OpenAPI schema handling and support concurrent requests #58024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Allow concurrent requests * test: Update test * test: Use Parallel.ForEachAsync * feat: Use valueFactory overload * feat: Pass valueFactory directly
dotnet-issue-labeler
bot
added
the
area-web-frameworks
captainsafia
added
area-mvc
BrennanConroy
approved these changes
Sep 24, 2024
src/OpenApi/src/Transformers/Implementations/OpenApiSchemaReferenceTransformer.cs
Outdated
Show resolved
Hide resolved
wtgodbe
added
Servicing-approved
|
Approved over email |
This was referenced Sep 25, 2024
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/aspnetcore/actions/runs/11056853055 |
|
@wtgodbe backporting to main failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix JsonUnmappedMemberHandling attribute handling to close #57981
Applying: Fix enum handling for MVC actions to close #57979
Applying: Fix self-referential schema handling to close #58006
Applying: Fix concurrent request handling for OpenAPI documents (#57972)
error: sha1 information is lacking or useless (src/OpenApi/src/Services/OpenApiDocumentService.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0004 Fix concurrent request handling for OpenAPI documents (#57972)
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@wtgodbe an error occurred while backporting to main, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
captainsafia
added a commit
that referenced
this pull request
Sep 26, 2024
* Fix JsonUnmappedMemberHandling attribute handling to close #57981 * Fix enum handling for MVC actions to close #57979 * Fix self-referential schema handling to close #58006 * Fix concurrent request handling for OpenAPI documents (#57972) * fix: Allow concurrent requests * test: Update test * test: Use Parallel.ForEachAsync * feat: Use valueFactory overload * feat: Pass valueFactory directly * Harden self-referencing schema ID check --------- Co-authored-by: Justin Lampe <[email protected]>
captainsafia
added a commit
that referenced
this pull request
Sep 26, 2024
… (#58096) * Fix JsonUnmappedMemberHandling attribute handling to close #57981 * Fix enum handling for MVC actions to close #57979 * Fix self-referential schema handling to close #58006 * Fix concurrent request handling for OpenAPI documents (#57972) * fix: Allow concurrent requests * test: Update test * test: Use Parallel.ForEachAsync * feat: Use valueFactory overload * feat: Pass valueFactory directly * Harden self-referencing schema ID check --------- Co-authored-by: Justin Lampe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports #57972 to resolve issues with concurrent requests to OpenAPI documents (fixes #57876).
This PR also addresses a set of issues with generated schemas:
Customer Impact
This PR resolves a set of bugs reported by users of .NET 9 RC 1 for which no viable workarounds exist.
Regression?
Risk
Changes localized to OpenAPI package.
Verification
Packaging changes reviewed?