Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] use x86_64 API 23 image on nightly pipeline #9414

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Oct 17, 2024

Context: dotnet/runtime#106025
Context: https://discord.com/channels/732297728826277939/732297837953679412/1296764055654240317

Mono.Android-Tests on API 23 crash on launch with:

09-17 14:41:32.839  2758  2758 I monodroid-assembly: Failed to load shared library '/data/app/Mono.Android.NET_Tests-1/split_config.x86.apk!/lib/x86/libSystem.Native.so'. dlopen failed: cannot find "libc.so" from verneed[1] in DT_NEEDED list for "/data/app/Mono.Android.NET_Tests-1/split_config.x86.apk"

But this same library appears to be correct, and loads on all of:

  • x86 API 21
  • x86_64 API 23
  • x86 API 24

This leads us to believe there is some kind of bug with loading native
libraries on the API 23 x86 emulator image.

For now, let's just target x86_64 on API 23 for the time being.

@jonathanpeppers

This comment was marked as outdated.

@jonathanpeppers

This comment was marked as outdated.

@jonathanpeppers

This comment was marked as outdated.

@jonathanpeppers

This comment was marked as outdated.

Context: dotnet/runtime#106025
Context: https://discord.com/channels/732297728826277939/732297837953679412/1296764055654240317

`Mono.Android-Tests` on API 23 crash on launch with:

    09-17 14:41:32.839  2758  2758 I monodroid-assembly: Failed to load shared library '/data/app/Mono.Android.NET_Tests-1/split_config.x86.apk!/lib/x86/libSystem.Native.so'. dlopen failed: cannot find "libc.so" from verneed[1] in DT_NEEDED list for "/data/app/Mono.Android.NET_Tests-1/split_config.x86.apk"

But this same library appears to be correct, and loads on all of:

* x86 API 21
* x86_64 API 23
* x86 API 24

This leads us to believe there is some kind of bug with loading native
libraries on the API 23 x86 emulator image.

For now, let's just target x86_64 on API 23 for the time being.
@jonathanpeppers jonathanpeppers force-pushed the dev/peppers/sdkmanager/update branch from 0d95633 to 2a2b47c Compare October 18, 2024 14:13
@jonathanpeppers jonathanpeppers changed the title [tests] run sdkmanager update before installing emulators [tests] use x86_64 API 23 image on nightly pipeline Oct 18, 2024
@jonathanpeppers
Copy link
Member Author

@jonathanpeppers
Copy link
Member Author

This is green now:

image

I just pushed a commit to fix the name, so it will say x86_64.

@jonathanpeppers jonathanpeppers marked this pull request as ready for review October 18, 2024 16:47
avdApiLevel: 23
avdAbi: x86
avdAbi: x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the goals of the nightly job was to increase our API/ABI coverage to catch potential issues like this. It seems possible that we have a regression here somewhere, but given that the potential impact is likely quite low I think this is reasonable.

@jonathanpeppers jonathanpeppers merged commit da0c8f6 into main Oct 18, 2024
56 of 58 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/peppers/sdkmanager/update branch October 18, 2024 18:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants