-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xamarin.Android.Build.Tasks] Bump MinimumSupportedJavaVersion=17 #9257
Conversation
Context: #9159 (comment) Bump `$(MinimumSupportedJavaVersion)` to 17.0, and base this value on the `Configurables.Defaults.MicrosoftOpenJDK17Version` value so that if (when) we bump the JDK we build against, the major version value of `$(MinimumSupportedJavaVersion)` follows suit. Additionally, remove the `$(MinimumSupportedJavaVersion)` definition in `Microsoft.Android.Sdk.DefaultProperties.targets` so that it's only defined in one location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this raising the min JDK to 17? for our whole product?
Should we consider:
- JDK 11 minimum for .NET 9
- JDK 17 minimum for .NET 10
Just wondering what might break if this goes out in RC 2.
Yes. Which may sound bananas, but:
TODO? What did/does VSMac provision? (And should we even care?) Thus, who could/would still be using JDK-11? Who could this break? Then there's the "real" reason I'm suggesting this: bumping
Bumping |
Also, I don't think any of our unit tests have used JDK-11 for quite some time (please correct me if I'm wrong), so it's entirely plausible that we don't fully work on JDK-11 now… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it breaks someone, they have the workaround for their project:
<MinimumSupportedJavaVersion>11.0</MinimumSupportedJavaVersion>
So, I think we should just put this in RC 2 release notes, and see if anything goes wrong.
Context: #9159 (comment)
Bump
$(MinimumSupportedJavaVersion)
to 17.0, and base this value on theConfigurables.Defaults.MicrosoftOpenJDK17Version
value so that if (when) we bump the JDK we build against, the major version value of$(MinimumSupportedJavaVersion)
follows suit.Additionally, remove the
$(MinimumSupportedJavaVersion)
definition inMicrosoft.Android.Sdk.DefaultProperties.targets
so that it's only defined in one location.