Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Add option to skip Mono MDK provisioning #8993

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

pjcollins
Copy link
Member

The mono related CLI parameters for xaprepare have been updated to make
it possible to skip installation of the Mono MDK via the following:

make prepare-update-mono PREPARE_AUTOPROVISION=1 PREPARE_AUTOPROVISION_SKIP_MONO=1
make prepare PREPARE_AUTOPROVISION=1 PREPARE_AUTOPROVISION_SKIP_MONO=1

Unused ignore-*-mono-version= parameters have been removed and
replaced with their default values.

Build warnings in the project have also been fixed on macOS.

pjcollins added 2 commits May 29, 2024 16:06
The mono related CLI parameters for xaprepare have been updated to make
it possible to skip installation of the Mono MDK via the following:

    make prepare-update-mono PREPARE_AUTOPROVISION=1 PREPARE_AUTOPROVISION_SKIP_MONO=1
    make prepare PREPARE_AUTOPROVISION=1 PREPARE_AUTOPROVISION_SKIP_MONO=1

Unused `ignore-*-mono-version=` parameters have been removed and
replaced with their default values.

Build warnings in the project have also been fixed on macOS.
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only thought, is do we need the MDK provisioning at all?

@pjcollins
Copy link
Member Author

My only thought, is do we need the MDK provisioning at all?

I do think we should try to remove it in a future PR, and these changes could let us test jobs one by one on machines where it is not already installed.

@pjcollins pjcollins merged commit dbc72c8 into main Jun 4, 2024
48 checks passed
@pjcollins pjcollins deleted the dev/pjc/optmono branch June 4, 2024 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants