Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump external/libunwind from 9cc4d98 to 8b9a387 #8956

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 17, 2024

Bumps external/libunwind from 9cc4d98 to 8b9a387.

Commits
  • 8b9a387 Add use of libabigail for ABI checks
  • 0be6732 Fixed miscompilation of unw_getcontext() on ARM
  • d8766d3 Fixed arm-linux FTBFS
  • 30041ef Fix following typos
  • b3ad2eb Bump the github-actions group with 2 updates
  • 8428e1f Replace clobber of CFLAGS in configure.ac
  • be0b15d Replace defining CPPFLAGS in configure.ac
  • 6aa693e Simplify --enable-debug
  • 96e0fef Remove explicit setting CCASFLAGS and AM_CCASFLAGS
  • 0f5d5a6 Add issue templates
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [external/libunwind](https://github.com/libunwind/libunwind) from `9cc4d98` to `8b9a387`.
- [Release notes](https://github.com/libunwind/libunwind/releases)
- [Commits](libunwind/libunwind@9cc4d98...8b9a387)

---
updated-dependencies:
- dependency-name: external/libunwind
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from jonpryor as a code owner May 17, 2024 02:34
@dependabot dependabot bot added dependencies Pull requests that update a dependency file. submodules Pull requests that update Submodules code labels May 17, 2024
@jonpryor jonpryor requested a review from grendello May 22, 2024 20:51
@jonpryor
Copy link
Member

@grendello: this PR updates external/libunwind to use the libunwind/master branch, while the commit #8857 uses is from the libunwind/v1.8-stable branch.

I think we should:

  1. Close/reject this PR
  2. Update .gitmodules to set the branch to v1.8-master
  3. Update .gitmodules so that formatting is consistent, i.e. spaces not tabs for xxHash, constexpr-xxh3, and libunwind.

@grendello
Copy link
Contributor

@grendello: this PR updates external/libunwind to use the libunwind/master branch, while the commit #8857 uses is from the libunwind/v1.8-stable branch.

I think we should:

  1. Close/reject this PR

I'd rather this submodule were under manual control, is there a way to make dependabot ignore it?

  1. Update .gitmodules to set the branch to v1.8-master

I'd rather not do that because we use tags for the module anyway, and using a branch means we'd have to change it again when they switch to 1.9-stable etc

  1. Update .gitmodules so that formatting is consistent, i.e. spaces not tabs for xxHash, constexpr-xxh3, and libunwind.

This is how git added it, maybe it's the new way? Do we really want to change stuff that's handled by git?

@grendello
Copy link
Contributor

#8978

@grendello grendello closed this May 23, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 23, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/submodules/external/libunwind-8b9a387 branch May 23, 2024 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file. submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants