Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Improve maestro artifact publishing #8945

Merged
merged 17 commits into from
May 15, 2024
Merged

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented May 15, 2024

Context: https://github.com/dotnet/arcade/blob/efc3da96e5ac110513e92ebd9ef87c73f44d8540/Documentation/DependencyFlowOnboardingWithoutArcade.md

The steps used to publish build asset information to maestro have been
updated.

With the new PushToAzureDevOpsArtifacts task the build pipeline should
now create all of the artifacts required for maestro artifact publishing.
The add-build-to-channel darc command will now trigger a
Build Promotion Pipeline that pushes build assets to the feed that
corresponds to the maestro channel that is being updated. We should
no longer need to push assets to various NuGet feeds in a separate step.

@pjcollins
Copy link
Member Author

pjcollins commented May 15, 2024

@pjcollins pjcollins marked this pull request as ready for review May 15, 2024 16:02
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could try our repo as the "guinea pig".

After merging, if our builds appear on the dotnet9 feed, then it should work for xamarin-macios and dotnet/maui?

@pjcollins
Copy link
Member Author

I set up corresponding PRs in the other repos, though they both handle things slightly differently and will need further testing before merging:

dotnet/maui#22431
xamarin/xamarin-macios#20604

@jonathanpeppers jonathanpeppers merged commit bbac9fe into main May 15, 2024
48 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/pjc/barmanfix branch May 15, 2024 20:02
grendello added a commit that referenced this pull request May 16, 2024
* main:
  [Mono.Android] AndroidMessageHandler should follow HTTP-308 redirects (#8951)
  [Microsoft.Android.Templates] Add icons to templates (#8883)
  [native] Native call tracing infra + native build system overhaul (#8857)
  [build] fix code-flow from dotnet/installer, .NET 9.0.100-preview.5.24262.2 (#8949)
  [ci] Re-enable to push to dotnet9 feed (#8950)
  LEGO: Merge pull request 8952
  [ci] Improve maestro artifact publishing (#8945)
grendello added a commit that referenced this pull request May 16, 2024
* main:
  [ci] Improve maestro artifact publishing (#8945)
jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this pull request May 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants