[ci] Add install-global-tool yaml template #8233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to install the boots global tool have been failing:
"C:\Program Files\dotnet\dotnet.exe" tool update boots -g --version 1.1.0.36 --add-source https://api.nuget.org/v3/index.json
The requested version 1.1.0.36 is lower than existing version 1.1.0.712-preview2.
Fix this by replacing the install-apkdiff and install-dotnet-test-slicer
templates with a generic install-global-tool template that is also used
to install boots.
jonathanpeppers
approved these changes
Aug 1, 2023
jpobst
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
While this is perfectly fine, a more complete fix might be to remove the boots installation completely if we no longer need it.
I suspect all of these could be false now and then we could remove them completely:
https://github.com/search?q=repo%3Axamarin%2Fxamarin-android%20installLegacyXamarinAndroid&type=code
But that can also be tackled separately if we don't want to look at it now.
|
The Eventually we will want to remove those tests and these provisioning steps, but probably not until after ~May 2024. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to install the boots global tool have been failing:
Fix this by replacing the install-apkdiff and install-dotnet-test-slicer templates with a generic install-global-tool template that is also used to install boots.