Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] fix 8.0.100-alpha.1 version band #7500

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

jonathanpeppers
Copy link
Member

Local builds were failing with:

make prepare all
...
build-tools/create-packs/Directory.Build.targets(280,5): error MSB3073: The command ""…/xamarin-android/bin/Debug/dotnet/dotnet" workload install android-deps --configfile "…/xamarin-android/NuGet.config" --skip-manifest-update --verbosity diag" exited with code 1.

android-deps is our workaround for installing the "abstract" Mono workload that we need to build against.

Since we are "inventing" this workload, there is not a way for the .NET workload system to fall back to older version bands.

And so:

bin/Debug/lib/sdk-manifests/8.0.100/android.deps.workload/WorkloadManifest.json

Doesn't work because the version band is actually 8.0.100-alpha.1.

Update our logic in eng/Versions.props to support alpha version bands.

Local builds were failing with:

    make prepare all
    ...
    build-tools/create-packs/Directory.Build.targets(280,5): error MSB3073: The command ""…/xamarin-android/bin/Debug/dotnet/dotnet" workload install android-deps --configfile "…/xamarin-android/NuGet.config" --skip-manifest-update --verbosity diag" exited with code 1.

`android-deps` is our workaround for installing the "abstract" Mono
workload that we need to build against.

Since we are "inventing" this workload, there is not a way for the .NET
workload system to fall back to older version bands.

And so:

    bin/Debug/lib/sdk-manifests/8.0.100/android.deps.workload/WorkloadManifest.json

Doesn't work because the version band is *actually* 8.0.100-alpha.1.

Update our logic in `eng/Versions.props` to support `alpha` version bands.
@jonpryor jonpryor merged commit 5f3deea into dotnet:main Oct 28, 2022
grendello added a commit to grendello/xamarin-android that referenced this pull request Oct 28, 2022
* main:
  [build] fix 8.0.100-alpha.1 version band (dotnet#7500)
@jonathanpeppers jonathanpeppers deleted the 8.0.100-alpha.1 branch October 28, 2022 14:47
grendello added a commit to grendello/xamarin-android that referenced this pull request Nov 4, 2022
* main:
  [Tests] Replace azurestorage with a github repo. (dotnet#7524)
  Bump to xamarin/Java.Interop/main@5318261 (dotnet#7502)
  [build] fix 8.0.100-alpha.1 version band (dotnet#7500)
  [monodroid] Disable loading of libLLVM at runtime (dotnet#7499)
  Bump to dotnet/installer@8c1708f 8.0.100-alpha.1.22526.2 (dotnet#7497)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants