-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Import regression test for bug 29730 #3748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3107238&view=ms.vss-test-web.test-result-details Context: https://bugzilla.xamarin.com/show_bug.cgi?id=29730 This test has been failing with some frequency since it was imported in the new Integrated Regression test Azure Pipeline jobs. After some investigation, it appears that the failure is due to test environment limitations. Some of the Android devices attached to the machine pools being used for this test job have a lock screen enabled, and in some cases this is preventing `ViewTreeObserver` events from executing. Fixes the intermittent failure by moving this test into the `MSBuildDeviceIntegration` suite which runs on an x86 emulator in CI. This emulator is never locked and should always display activites for applications we're installing and launching.
dellis1972
approved these changes
Oct 7, 2019
The test addition failed in Debug mode it seems, but was working for me locally. I'll need to take another look, perhaps there is another issue here. |
@dellis1972 The test failures on the latest run appear to be unrelated, this should be ready to merge if the latest changes look good to you? |
dellis1972
reviewed
Oct 9, 2019
dellis1972
approved these changes
Oct 9, 2019
jonpryor
pushed a commit
that referenced
this pull request
Oct 9, 2019
Context: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3107238&view=ms.vss-test-web.test-result-details Context: https://bugzilla.xamarin.com/show_bug.cgi?id=29730 This test has been failing with some frequency since it was imported in the new Integrated Regression test Azure Pipeline jobs. After some investigation, it appears that the failure is due to test environment limitations. Some of the Android devices attached to the machine pools being used for this test job have a lock screen enabled, and in some cases this is preventing ViewTreeObserver events from executing. Fixes the intermittent failure by moving this test into the MSBuildDeviceIntegration suite which runs on an x86 emulator in CI. This emulator is never locked and should always display activites for applications we're installing and launching.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3107238&view=ms.vss-test-web.test-result-details
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=29730
This test has been failing with some frequency since it was imported in
the new Integrated Regression test Azure Pipeline jobs. After some
investigation, it appears that the failure is due to test environment
limitations. Some of the Android devices attached to the machine pools
being used for this test job have a lock screen enabled, and in some
cases this is preventing
ViewTreeObserver
events from executing.Fixes the intermittent failure by moving this test into the
MSBuildDeviceIntegration
suite which runs on an x86 emulator in CI.This emulator is never locked and should always display activites for
applications we're installing and launching.