Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Import regression test for bug 29730 #3748

Merged
merged 3 commits into from
Oct 9, 2019

Conversation

pjcollins
Copy link
Member

Context: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3107238&view=ms.vss-test-web.test-result-details
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=29730

This test has been failing with some frequency since it was imported in
the new Integrated Regression test Azure Pipeline jobs. After some
investigation, it appears that the failure is due to test environment
limitations. Some of the Android devices attached to the machine pools
being used for this test job have a lock screen enabled, and in some
cases this is preventing ViewTreeObserver events from executing.

Fixes the intermittent failure by moving this test into the
MSBuildDeviceIntegration suite which runs on an x86 emulator in CI.
This emulator is never locked and should always display activites for
applications we're installing and launching.

Context: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3107238&view=ms.vss-test-web.test-result-details
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=29730

This test has been failing with some frequency since it was imported in
the new Integrated Regression test Azure Pipeline jobs. After some
investigation, it appears that the failure is due to test environment
limitations. Some of the Android devices attached to the machine pools
being used for this test job have a lock screen enabled, and in some
cases this is preventing `ViewTreeObserver` events from executing.

Fixes the intermittent failure by moving this test into the
`MSBuildDeviceIntegration` suite which runs on an x86 emulator in CI.
This emulator is never locked and should always display activites for
applications we're installing and launching.
@pjcollins pjcollins requested a review from dellis1972 October 7, 2019 16:34
@pjcollins pjcollins requested a review from jonpryor as a code owner October 7, 2019 16:34
@pjcollins pjcollins added the do-not-merge PR should not be merged. label Oct 7, 2019
@pjcollins
Copy link
Member Author

pjcollins commented Oct 7, 2019

The test addition failed in Debug mode it seems, but was working for me locally. I'll need to take another look, perhaps there is another issue here.

@pjcollins pjcollins removed the do-not-merge PR should not be merged. label Oct 7, 2019
@pjcollins
Copy link
Member Author

@dellis1972 The test failures on the latest run appear to be unrelated, this should be ready to merge if the latest changes look good to you?

@pjcollins pjcollins merged commit 438a598 into dotnet:master Oct 9, 2019
@pjcollins pjcollins deleted the testbug29730 branch October 9, 2019 19:11
jonpryor pushed a commit that referenced this pull request Oct 9, 2019
Context: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3107238&view=ms.vss-test-web.test-result-details
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=29730

This test has been failing with some frequency since it was imported in
the new Integrated Regression test Azure Pipeline jobs. After some
investigation, it appears that the failure is due to test environment
limitations. Some of the Android devices attached to the machine pools
being used for this test job have a lock screen enabled, and in some
cases this is preventing ViewTreeObserver events from executing.

Fixes the intermittent failure by moving this test into the
MSBuildDeviceIntegration suite which runs on an x86 emulator in CI.
This emulator is never locked and should always display activites for
applications we're installing and launching.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants