[msbuild] fix ClassParse task log message. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was printing {0} as is.
jonpryor
added a commit
that referenced
this pull request
Jan 10, 2017
…#357) Reverts #337 Commit a7beb70 broke unit test execution. [Jenkins build #190][b190] ran 128 tests, while [Jenkins build #191][b190] executed *6*. Build #191 only contains two commits, and commit bf1bc93 -- [PR #354][pr354] -- doesn't look like a plausible source of error. The cause of the "broken unit test execution" is that the on-device unit tests are exiting [with an error][x191]: Task "RunInstrumentationTests" .... INSTRUMENTATION_RESULT: shortMsg=android.runtime.JavaProxyThrowable INSTRUMENTATION_RESULT: longMsg=android.runtime.JavaProxyThrowable: System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime.Serialization, Version=2.0.5.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' or one of its dependencies. ... xamarin-android/build-tools/scripts/UnitTestApks.targets: warning : No `nunit2-results-path` bundle value found in command output! Cannot find NUnit2 XML output! Commit a7beb70 stopped deploying facade assemblies, including `System.Runtime.Serialization`, which is why it can't be found. Revert commit a7beb70 so that on-device unit tests execute. [b190]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/190/testReport/ [b191]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/191/testReport/ [x191]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/191/consoleText [pr354]: #354
radical
pushed a commit
that referenced
this pull request
May 8, 2018
It had annoyed me by reporting warnings on android.app.Notification.Action as "Android.App.Action", which doesn't exist. It was due to careless use of GenBase.Name combined with GenBase.Namespace which never cared about nested types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was printing {0} as is.