Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wording/costmetic issues with Android item templates #8626

Closed
BretJohnson opened this issue Jan 11, 2024 · 2 comments · Fixed by #8773
Closed

Wording/costmetic issues with Android item templates #8626

BretJohnson opened this issue Jan 11, 2024 · 2 comments · Fixed by #8773
Assignees
@jpobst
Labels
Area: Templates Issues with templates shipped with the Android workload.

Comments

@BretJohnson
Copy link
Member

Android application type

.NET Android (net7.0-android, net8.0-android, etc.)

Affected platform version

VS 2022 17.8

Description

In the past Android Item templates didn't show up in VS, for some reason. They are now visible now, which reveals some costmetic issues:

  • They shouldn't include the word "template", as none of the other templates do that. Should be "Android Activity", not "Android Activity template"
  • The icons should be updated, not using the default icon.

image

Compare to the MAUI item templates for instance:
image

Steps to Reproduce

  1. File > New Project > Android Application (or .NET MAUI)
  2. Right click on the project in solution explorer and do Add > Item
  3. Click on the different categories to see conventions followed
  4. Click on Android to see the Android templates, and note the "template" suffix in the name that shouldn't be there and the default icons

Did you find any workaround?

No response

Relevant log output

No response
@BretJohnson BretJohnson added the needs-triage Issues that need to be assigned. label Jan 11, 2024
@BretJohnson
Copy link
Member Author

cc @jonpryor as we discussed this briefly in the Tools/SDK sync

@jpobst
Copy link
Contributor

jpobst commented Jan 11, 2024

Do we have a resource for getting icons for these templates? The ones we have for Xamarin.Android do not fit the current VS look and feel:

image

@jpobst jpobst added Area: Templates Issues with templates shipped with the Android workload. and removed needs-triage Issues that need to be assigned. labels Jan 24, 2024
@jpobst jpobst mentioned this issue Feb 28, 2024
Merged
jpobst added a commit that referenced this issue Mar 7, 2024
@jpobst
[templates] Remove redundant "template" from display name. (#8773)
9d8ca60 
Fixes: #8626

Removes the word "template" that shows up in the New Item dialog box, as it is unnecessary.

The original issue also mentions not having a custom icon, but as we don't have any of those available, the default icon seems good enough.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jpobst jpobst

Labels
Area: Templates Issues with templates shipped with the Android workload.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[templates] Remove redundant "template" from display name. dotnet/android
2 participants
@jpobst @BretJohnson