Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[android-toolchain] Fix the
_CreateMxeW32Toolchain
Condition. (#122)
The `_CreateMxeW32Toolchain` target condition checked for `:mxe-Win64:`, not `:mxe-Win32:`, which caused it to needlessly run whenever `:mxe-Win64:` was set (spending extra time), while *not* running when it was requested, i.e. when `:mxe-Win32:` was set. Additionally, I previously had an MXE SNAFU wherein `android-toolchain.targets` was updated to build `zlib`, but my local build output *didn't contain `zlib` outputs*. This resulted in obscure build errors and needless tearing out of limited hair, which could have been avoided if the `zlib` outputs had been listed as outputs that could be checked for. Thus, rework the existing `_CreateMxeW32Toolchain` and `_CreateMxeW64Toolchain` dichotomy, and instead introduce a new `@(_AndroidMxeToolchain)` item group with conditional values based on `$(AndroidSupportedHostJitAbisForConditionalChecks)`. This allows for a more "extensible" output file format that doesn't needlessly copy obscure identifiers like `i686-w64-mingw32.static` for output files. `_CreateMxeW32Toolchain` and `_CreateMxeW64Toolchain` are dead; long live `_CreateMxeToolchains`!
- Loading branch information