[d17-0][build] Allow Assembly "vendorization" (#136) #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: ff73f92
Context: 061bcc2
Context: https://github.com/xamarin/XamarinVS/pull/12550
Changing
$(Version)
with every commit is fun and all, but doesn'tsolve all problems. Commit ff73f92 works "nicely" for MSBuild tasks
via
<UsingTask/>
. It doesn't work as well for "normal"assembly references in a "normal" AppDomain context, because
assemblies are normally resolved via "assembly base name", not
the full path name including directory.
Thus, given
Example.dll
:then when
Example.dll
is loaded, it will try to loadXamarin.Android.Tools.AndroidSdk
via aLoad-by-name
method, andwill load the first
Xamarin.Android.Tools.AndroidSdk.dll
loadedinto the
AppDomain
/AssemblyLoadContext
, regardless of version.There may not be a good way to control what that assembly is.
This causes grief with our peer IDE teams, as assembly versions are
still checked, but on mismatch an exception is thrown (!).
Commit 061bcc2 was an attempt to address this, but proved to be
incomplete.
Attempt to improve matters by introducing a "vendorization" protocol:
Update
Directory.Build.props
to import"parent directory.override.props", so that a "parent checkout"
can easily override MSBuild properties.
Update the
*.csproj
files so that$(AssemblyName)
is forcedto start with
$(VendorPrefix)
, and end with$(VendorSuffix)
.This allows a parent checkout to set the
$(VendorPrefix)
and$(VendorSuffix)
properties, which will impact the assembly filenamesof all assemblies built in xamarin-android-tools.