Fix for issue #149 - Adding F# support for AssemblyInfo generation #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @kwpatrick. I made a few mainly cosmetic changes, but I like what you've done here. |
AArnott
added a commit
that referenced
this pull request
Apr 1, 2024
Bump .NET SDK from 8.0.100 to 8.0.201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding F# support involved some minor changes to how the assembly infos are generated, since the NET461 target now needs to be able to try both CodeDom and native code generation paths. This resolves issue #149.
One thing to note: F# requires code to be in a module or namespace, and so the new F# path will apply a namespace (the provided root namespace + "Properties" if possible, "AssemblyInfo.Properties" if nothing is provided. Other code generation targets should be unaffected by this.