Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GitCommitDate being author date rather than commit date #1103

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

DmitryZhelnin
Copy link

Fill GitCommitDate with actual value of commit date.
Add GitCommitAuthorDate property for convenience.

fixes #827

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@AArnott
Copy link
Collaborator

AArnott commented Oct 9, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AArnott
Copy link
Collaborator

AArnott commented Oct 9, 2024

Actually something about this caused a bunch of tests to fail. @DmitryZhelnin can you look into that?

@DmitryZhelnin
Copy link
Author

Actually something about this caused a bunch of tests to fail. @DmitryZhelnin can you look into that?

Sure, I'll investigate.

@DmitryZhelnin
Copy link
Author

@AArnott I'm sorry, there were some missing changes. Tests should be OK now.

@AArnott AArnott added this to the v3.7 milestone Oct 9, 2024
@AArnott AArnott merged commit 41ee52c into dotnet:main Oct 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitCommitDate is author date rather than commit date
2 participants