Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReleaseManager: do not reset VersionHeightOffset if it equals to -1 #1100

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

DmitryZhelnin
Copy link

@DmitryZhelnin DmitryZhelnin commented Oct 3, 2024

Fixes #1058

Add additional check if VersionHeightOffset equals to -1 during execution of prepare-release command

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. One change please.

src/NerdBank.GitVersioning/ReleaseManager.cs Outdated Show resolved Hide resolved
@AArnott AArnott added this to the v3.7 milestone Oct 3, 2024
@DmitryZhelnin DmitryZhelnin changed the title ReleaseManager: do not reset negative VersionHeightOffset ReleaseManager: do not reset VersionHeightOffset if it equals to -1 Oct 3, 2024
@AArnott AArnott merged commit b234ff8 into dotnet:main Oct 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with nbgv prepare-release Command Removing versionHeightOffset in ReleaseFlow Branching Strategy
3 participants